commit f9b3761912e108c93d3a9eb993d2aa8e317be9b6 Author: Raul Gutierrez Segales Date: Mon Aug 29 10:18:50 2011 +0100 Release version 0.6.1 configure.ac | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit 1cfbeb84986f3e1072387a903b08acdd251b074d Author: Raul Gutierrez Segales Date: Mon Aug 29 10:49:56 2011 +0100 tracker: catch GLib.SpawnError when getting a connection tests/lib/tracker/backend.vala | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit 93e84b90f26e407a9949dd66f837de2ceeaba12c Author: Raul Gutierrez Segales Date: Mon Aug 29 10:02:05 2011 +0100 Add myself as maintainer so I can upload tarballs, etc folks.doap | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) commit 2a81e402ec9758821e2fd7eac9177f741dc29aab Author: Philip Withnall Date: Sat Aug 27 16:25:11 2011 +0100 tracker: Remove “alias” from the writeable properties list of Trf.Persona Trf.Persona no longer implements AliasDetails. backends/tracker/lib/trf-persona.vala | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit 92c819b7f0fccc742f8de464969abf8316384172 Author: Philip Withnall Date: Thu Aug 25 19:17:27 2011 +0100 Bug 657332 — Add linking link-individuals Add a `linking link-individuals` subcommand to folks-inspect. Note: this appears to break readline command completion for the `linking` command in certain situations (e.g. if you tab-complete the name of the command first). I can't fix this for love or money. Pigs will fly before I manage to work out why readline hates me so much. Closes: bgo#657332 NEWS | 1 + tools/inspect/command-linking.vala | 127 +++++++++++++++++++++++++++-------- 2 files changed, 99 insertions(+), 29 deletions(-) commit 99670bd47ba523c3b0c77277280a4391416a4a26 Author: Travis Reitter Date: Fri Aug 26 10:33:38 2011 -0700 Don't require that zero Individuals be removed after auto-linking. tests/tracker/match-im-addresses.vala | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit 274b4c097080f21b56b8446664578627d78bf7f9 Author: Travis Reitter Date: Fri Aug 26 10:31:36 2011 -0700 Make sure Tracker tests actually use the Tracker backend for writes. tests/tracker/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit d4922aed17bdd8c7f0e1feb63440edae7fb2f3a0 Author: Travis Reitter Date: Fri Aug 26 10:16:17 2011 -0700 Ignore edsf-persona-store.c for translations. po/POTFILES.skip | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit be452e9eb223a7b246b8b9bd742901a5e7c3b9b1 Author: Travis Reitter Date: Fri Aug 26 09:41:05 2011 -0700 Properly handle 'url' TYPE for URLs in Tracker backend. backends/tracker/lib/trf-persona-store.vala | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit 38dda59b515d676ec800c13f3dfa95099fd0a8a2 Author: Travis Reitter Date: Fri Aug 26 08:00:32 2011 -0700 Correctly spell ERROR_VALAFLAGS. backends/tracker/lib/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 91e0be11c5ba509e5dc21f559f6b66117ae1868d Author: Travis Reitter Date: Fri Aug 26 07:59:31 2011 -0700 Don't use ERROR_CFLAGS yet. Vala doesn't guarantee warning-free C. folks/Makefile.am | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit ef36f347ea24cfa3ea35cc5010b4e5ff4ccd878f Author: Travis Reitter Date: Fri Aug 26 07:47:44 2011 -0700 Use the key-file backend for writes in tests for non-writeable backends. We could have used the EDS backend, but this helps keep the execution of the tests as simple as possible. This fixes a bug in the libsocialweb aggregation test where it was using the EDS backend from the Aggregator default but its FOLKS_BACKEND_STORE_KEY_FILE_PATH didn't include the EDS backend, so it had nowhere to store its linking personas. tests/libsocialweb/Makefile.am | 1 + tests/telepathy/Makefile.am | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) commit 0ae626ee3cedaabc387665193ca40a2739904671 Author: Raul Gutierrez Segales Date: Fri Aug 26 13:19:59 2011 +0100 e-d-s: add urls to list of writeable properties backends/eds/lib/edsf-persona.vala | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit 73c6ed7198f4ef41faf229bd56087062ab36e2e2 Author: Raul Gutierrez Segales Date: Fri Aug 26 11:55:18 2011 +0100 IndividualAggregator: initialize primary-store property to NULL folks/individual-aggregator.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 356b3c729c327b28683de41a6615f7fc0e1ade50 Author: Raul Gutierrez Segales Date: Fri Aug 26 11:32:05 2011 +0100 IndividualAggregator: emit notifications for primary-store property folks/individual-aggregator.vala | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) commit a2fc4e5744753462f42df45ab33e390c0b69ccbc Author: Raul Gutierrez Segales Date: Fri Aug 26 11:31:25 2011 +0100 IndividualAggregator: state that the primary-store can be null folks/individual-aggregator.vala | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit f32af263adbe086653700a17806efbad222fbcff Author: Travis Reitter Date: Thu Aug 25 15:11:59 2011 -0700 Hold a pointer to delegates; don't copy them. tests/lib/test-case.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 94dca5969265601e9ca8c9ae044e8fe9b3a13214 Author: Travis Reitter Date: Thu Aug 25 15:06:19 2011 -0700 Use ERROR_VALAFLAGS as intended. backends/eds/Makefile.am | 1 + backends/eds/lib/Makefile.am | 1 + backends/libsocialweb/Makefile.am | 1 + backends/libsocialweb/lib/Makefile.am | 1 + backends/telepathy/Makefile.am | 1 + backends/telepathy/lib/Makefile.am | 1 + backends/tracker/Makefile.am | 1 + backends/tracker/lib/Makefile.am | 1 + folks/Makefile.am | 2 ++ tests/eds/Makefile.am | 1 + tests/folks/Makefile.am | 1 + tests/key-file/Makefile.am | 1 + tests/lib/Makefile.am | 1 + tests/lib/eds/Makefile.am | 1 + tests/lib/key-file/Makefile.am | 1 + tests/lib/libsocialweb/Makefile.am | 1 + tests/lib/tracker/Makefile.am | 1 + tests/libsocialweb/Makefile.am | 1 + tests/telepathy/Makefile.am | 1 + tests/tracker/Makefile.am | 1 + 20 files changed, 21 insertions(+), 0 deletions(-) commit fa38471cd772613c5c78f8bd769c117cb18fcc57 Author: Travis Reitter Date: Thu Aug 25 14:28:06 2011 -0700 Build tests with extra debug information. Notably, this provides gdb with Vala source file line numbers for backtraces (which should save a bit of digging through generated C files). Gdb still lists generated C line numbers for lines farther up the stack when there's no obvious Vala line equivalent. configure.ac | 5 +++++ tests/eds/Makefile.am | 1 + tests/folks/Makefile.am | 1 + tests/key-file/Makefile.am | 1 + tests/lib/Makefile.am | 1 + tests/lib/eds/Makefile.am | 1 + tests/lib/key-file/Makefile.am | 1 + tests/lib/libsocialweb/Makefile.am | 1 + tests/lib/tracker/Makefile.am | 1 + tests/libsocialweb/Makefile.am | 1 + tests/telepathy/Makefile.am | 1 + tests/tracker/Makefile.am | 1 + 12 files changed, 16 insertions(+), 0 deletions(-) commit 8e359ce63d151fbb52678e34c47541868b771b77 Author: Travis Reitter Date: Wed Aug 24 10:50:54 2011 -0700 Add test case for properties race condition. tests/eds/Makefile.am | 6 ++ tests/eds/set-properties-race.vala | 174 ++++++++++++++++++++++++++++++++++++ 2 files changed, 180 insertions(+), 0 deletions(-) commit 453f694418e4a2325c00f73b449dcd9703c4f365 Author: Philip Withnall Date: Wed Aug 24 21:23:30 2011 +0100 eds: Tell Vala to not notify of property changes in the setter functions We only want to notify of property changes when we get notification back from eds that the change was successful. backends/eds/lib/edsf-persona.vala | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) commit 71b46631f5e28190d6bf50348e54de0465174cc1 Author: Philip Withnall Date: Mon Aug 22 20:23:50 2011 +0100 build: Bump the Vala dependency to 0.13.3 This is due to commit c0ecad63015078231934e63ec63f02b97defb730. configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit c0ecad63015078231934e63ec63f02b97defb730 Author: Raul Gutierrez Segales Date: Mon Aug 22 13:51:28 2011 +0100 e-d-s: Vala dropped support for reordering GCancellable params A couple of e-d-s methods (get_contact, modify_contact, get_backend_property, etc) experienced an automatic API change in it's Vala binding due to Vala dropping support for reordering GCancellable params. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657067 NEWS | 1 + backends/eds/lib/edsf-persona-store.vala | 35 +++++++++++++++-------------- tests/lib/eds/backend.vala | 10 ++++---- 3 files changed, 24 insertions(+), 22 deletions(-) commit 28a2ed20d490226711fc0c583a80623da88b01a2 Author: Philip Withnall Date: Sun Aug 21 12:10:22 2011 +0100 core: Fix some whitespace folks/persona-store.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit b9bb49d6b032d930b666f42bb0f73ad8708d15e6 Author: Raul Gutierrez Segales Date: Wed Aug 17 15:48:39 2011 +0100 e-d-s: ignore the type when comparing images backends/eds/lib/memory-icon.vala | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) commit 7b595b5f4ae9326680866be204e5d15193b909a7 Author: Raul Gutierrez Segales Date: Mon Aug 15 13:30:42 2011 +0100 e-d-s: update the Avatar Details test Now that we've reworked avatar handling and we've introduced an Avatar cache, the avatars associated to a newly created e-d-s contact might not be immediately available after the corresponding Edsf.Persona is created. Hence we need to listen to notifications for the avatar property. tests/eds/avatar-details.vala | 30 +++++++++++++++++++++--------- 1 files changed, 21 insertions(+), 9 deletions(-) commit e3017a4bfc6a6940e2fb91dd8022ab8f817e9cbb Author: Raul Gutierrez Segales Date: Thu Aug 4 16:09:12 2011 +0100 e-d-s: Only set avatar if store_avatar () was successful Helps: https://bugzilla.gnome.org/show_bug.cgi?id=655374 backends/eds/lib/edsf-persona.vala | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) commit 8f747c7361bea1eefbae5358df44b161c2f432c4 Author: Raul Gutierrez Segales Date: Thu Aug 4 16:08:06 2011 +0100 e-d-s: When an avatar has been removed, set it to null Though new_avatar was null, I prefer to even more obvious about what is going on. Helps: https://bugzilla.gnome.org/show_bug.cgi?id=655374 backends/eds/lib/edsf-persona.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 5752726049d9b27af3083f9358a74a29a78e8061 Author: Raul Gutierrez Segales Date: Thu Aug 4 15:55:09 2011 +0100 e-d-s: Don't infer we already have an avatar in our cache by its URI From libfolks we should discourage using local URIs to set an EContactPhoto so even if we get inlined EContactPhoto just do a full content comparison. Helps: https://bugzilla.gnome.org/show_bug.cgi?id=655374 backends/eds/lib/edsf-persona.vala | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-) commit 19ae7a8f60aa04dc0548a41e6c976c3654709c22 Author: Raul Gutierrez Segales Date: Thu Aug 4 15:44:28 2011 +0100 Don't manipulate the Avatar Cache before e-d-s acks changes Also, lets set EContactPhotos as INLINED because it doesn't make sense to use URIs for local files. In the future, when we support gravatars, we'll have to handle the case of setting ContactPhotos as URIs for those. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=655374 backends/eds/lib/edsf-persona-store.vala | 51 +++++++++++++++++------------- 1 files changed, 29 insertions(+), 22 deletions(-) commit d7797088fbb5dd1a480e5ffd3b51b406a2409d3d Author: Travis Reitter Date: Thu Jul 28 10:08:09 2011 -0700 Do Tracker tests last, since they're most likely to fail uncontrollably. Helps: bgo#655374 - Un-break Tracker avatar tests tests/Makefile.am | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 22a72f0579e37a6ddb113846eb373a5c8995cfed Author: Travis Reitter Date: Tue Jul 26 15:53:02 2011 -0700 Add utility function to compare LoadableIcon content. Unlike the various "equal()" functions for LoadableIcon and related classes, this function actually compares image content (which can be necessary when testing vs. images in the avatar cache, which may have a different path than an otherwise-identical image). Helps: bgo#655374 - Un-break Tracker avatar tests NEWS | 1 + tests/eds/add-persona.vala | 24 ++++++---- tests/eds/avatar-details.vala | 8 ++- tests/eds/set-avatar.vala | 13 ++++-- tests/folks/avatar-cache.vala | 53 ++++++----------------- tests/lib/Makefile.am | 7 ++- tests/lib/test-utils.vala | 94 ++++++++++++++++++++++++++++++++++++++++ tests/tracker/add-persona.vala | 23 +++++++--- tests/tracker/set-avatar.vala | 19 +++++--- 9 files changed, 168 insertions(+), 74 deletions(-) commit 9d7520c898636680b43861551e342a22caed0738 Author: Raul Gutierrez Segales Date: Wed Aug 17 01:28:50 2011 +0100 Update NEWS file NEWS | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit 6b98480975464f9cadadd3841bc08ca38b69bd4f Author: Alexander Larsson Date: Tue Aug 16 16:53:14 2011 +0200 eds: Support writing postal addresses as vcards https://bugzilla.gnome.org/show_bug.cgi?id=656659 backends/eds/lib/edsf-persona-store.vala | 39 +++++++++-------------------- 1 files changed, 12 insertions(+), 27 deletions(-) commit 36c967607516279b606d6f2a88c0bb6942aa8a68 Author: Alexander Larsson Date: Tue Aug 16 14:06:33 2011 +0200 Generalize Edsf.PersonaStore._set_contact_attributes We need to handle non-string field details values when we implement postal addresses. https://bugzilla.gnome.org/show_bug.cgi?id=656659 backends/eds/lib/edsf-persona-store.vala | 27 ++++++++++++++++++++------- 1 files changed, 20 insertions(+), 7 deletions(-) commit a58f2d813ebb38149c02352e3055ab7dba7d5611 Author: Alexander Larsson Date: Tue Aug 16 14:06:10 2011 +0200 Read postal addresses as vcards https://bugzilla.gnome.org/show_bug.cgi?id=656659 backends/eds/lib/edsf-persona.vala | 84 ++++++++++++++++++++++++++---------- 1 files changed, 61 insertions(+), 23 deletions(-) commit 7c2d5de039655b0db66f80a723a3c8d4be9d977d Author: Alexander Larsson Date: Tue Aug 16 14:04:44 2011 +0200 Break out common code in edsf backend Most types use the same code to update the vcard params, so we can share this code. https://bugzilla.gnome.org/show_bug.cgi?id=656659 backends/eds/lib/edsf-persona.vala | 40 ++++++++++++++--------------------- 1 files changed, 16 insertions(+), 24 deletions(-) commit 0cac5985a3092f29f44491bced0da0569cb7a814 Author: Philip Withnall Date: Tue Aug 16 21:41:47 2011 +0100 inspect: Ensure to initialise out variables This fixes a few compiler warnings. tools/inspect/command-signals.vala | 6 ++++++ tools/inspect/inspect.vala | 4 ++++ tools/inspect/signal-manager.vala | 5 ++++- 3 files changed, 14 insertions(+), 1 deletions(-) commit 718d86b8ec95e85b684816be0e9d4ae5523214fa Author: Philip Withnall Date: Tue Aug 16 21:41:32 2011 +0100 core: Fix use of deprecated Vala API folks/individual-aggregator.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 4ed30316663e913ef1bbf293482b3d093c46aa4d Author: Philip Withnall Date: Tue Aug 16 19:40:35 2011 +0100 eds: Don't copy EVCardAttributes at all libebook does some icky things with EVCardAttributes it's passed, especially when calling e_vcard_remove_attribute() (it removes by pointer comparison and then unconditionally frees the passed-in attribute). Consequently, we need to do everything we can to avoid copying EVCardAttributes unless we want double-frees and memory leaks. backends/eds/lib/edsf-persona-store.vala | 43 ++++++++++++++++------------- 1 files changed, 24 insertions(+), 19 deletions(-) commit 96da6b9da72a754597b940c065154e0acf0f1a00 Author: Raul Gutierrez Segales Date: Tue Aug 16 20:03:03 2011 +0100 Don't use const string[] , Vala doesn't handle them correctly backends/libsocialweb/lib/swf-persona.vala | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) commit f7767014b984fae5df9b9c0d6b0df5fe10aba360 Author: Alexander Larsson Date: Tue Aug 16 14:03:17 2011 +0200 Make sure we pass ENABLE_EDS to vala flags folks/Makefile.am | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit c04d74bc561c6870c007ab83e2c406e7d66b28aa Author: Philip Withnall Date: Sun Aug 14 18:48:37 2011 +0100 inspect: Remove workarounds for bgo#638363 See also: bgo#656467. tools/inspect/utils.vala | 27 +++++++++------------------ 1 files changed, 9 insertions(+), 18 deletions(-) commit a5e75fb7624bf0d7de9c5a73dc8decf74a130fbb Author: Travis Reitter Date: Sat Aug 13 18:58:00 2011 +0200 Post-release version bump. configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit fb0afc67b31c095bbb3916547cd66025a873078c