commit df7e6b1b78cb6b17c6f213630618c284dc3b5eb6 Author: Raul Gutierrez Segales Date: Thu Sep 8 09:44:16 2011 +0100 Release version 0.6.2 configure.ac | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) commit b28b1036688ae117bfb48cc1989de3458a3a2ef7 Author: Raul Gutierrez Segales Date: Thu Sep 8 09:21:04 2011 +0100 Update @since tags backends/eds/eds-backend.vala | 2 +- backends/eds/lib/edsf-persona-store.vala | 4 +- backends/eds/lib/edsf-persona.vala | 38 +++++++++++----------- backends/key-file/kf-backend.vala | 2 +- backends/key-file/kf-persona-store.vala | 4 +- backends/key-file/kf-persona.vala | 6 ++-- backends/libsocialweb/lib/swf-persona-store.vala | 4 +- backends/libsocialweb/sw-backend.vala | 2 +- backends/telepathy/lib/tpf-persona-store.vala | 4 +- backends/telepathy/lib/tpf-persona.vala | 6 ++-- backends/telepathy/tp-backend.vala | 2 +- backends/tracker/lib/trf-persona-store.vala | 4 +- backends/tracker/lib/trf-persona.vala | 32 +++++++++--------- backends/tracker/tr-backend.vala | 2 +- folks/alias-details.vala | 2 +- folks/avatar-details.vala | 2 +- folks/backend.vala | 2 +- folks/birthday-details.vala | 4 +- folks/email-details.vala | 2 +- folks/favourite-details.vala | 2 +- folks/gender-details.vala | 2 +- folks/group-details.vala | 2 +- folks/im-details.vala | 2 +- folks/individual-aggregator.vala | 10 +++--- folks/individual.vala | 10 +++--- folks/local-id-details.vala | 2 +- folks/name-details.vala | 6 ++-- folks/note-details.vala | 2 +- folks/persona-store.vala | 8 ++-- folks/persona.vala | 8 ++-- folks/phone-details.vala | 2 +- folks/postal-address-details.vala | 2 +- folks/role-details.vala | 2 +- folks/url-details.vala | 2 +- folks/web-service-details.vala | 2 +- 35 files changed, 94 insertions(+), 94 deletions(-) commit ef1822b4a44d1c22adffd5e3f6f6a264f74a0ea5 Author: Fran Dieguez Date: Thu Sep 8 04:01:17 2011 +0200 Updated galician translations po/gl.po | 124 +++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 67 insertions(+), 57 deletions(-) commit adc28e2802496ffa2f00d035b3862bc9873ec1ac Author: Raul Gutierrez Segales Date: Wed Sep 7 23:10:38 2011 +0100 Updated NEWS file NEWS | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 6ba0b7484b83b019480ab8c6e1537cff9c2495a9 Author: Raul Gutierrez Segales Date: Wed Sep 7 23:04:07 2011 +0100 tracker: update link personas test tests/tracker/link-personas.vala | 13 ------------- 1 files changed, 0 insertions(+), 13 deletions(-) commit 53515f94ca402219d5de59f3393e749880974e32 Author: Raul Gutierrez Segales Date: Wed Sep 7 23:03:32 2011 +0100 tracker: update IM addresses updates test tests/tracker/imaddresses-updates.vala | 52 +++++++++++++------------------ 1 files changed, 22 insertions(+), 30 deletions(-) commit dec3da1c8db3fa39c39cd46cb328f461d8b95de4 Author: Raul Gutierrez Segales Date: Wed Sep 7 23:02:28 2011 +0100 tracker: update add persona tes tests/tracker/add-persona.vala | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) commit 097f622cb21d2f6e1f8f706baab50141eb0fdfe6 Author: Raul Gutierrez Segales Date: Wed Sep 7 23:01:59 2011 +0100 tracker: update set-im-addresses test Because IM addresses are linkable property, a new Individual is created when they are modified. tests/tracker/set-im-addresses.vala | 52 +++++++++++++++++++--------------- 1 files changed, 29 insertions(+), 23 deletions(-) commit d9d9a7ab754a5174fcde3ca94f9248f253d8bfed Author: Raul Gutierrez Segales Date: Wed Sep 7 23:01:19 2011 +0100 e-d-s: update set-im-addresses test Because IM addresses are linkable property, a new Individual is created when they are modified. tests/eds/set-im-addresses.vala | 41 ++++++++++++++++++-------------------- 1 files changed, 19 insertions(+), 22 deletions(-) commit a2837fa5a392daa8d54d159a974cb317baf59feb Author: Raul Gutierrez Segales Date: Wed Sep 7 23:00:48 2011 +0100 e-d-s: only emit notifications if linkable properties changed Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658411 NEWS | 2 + backends/eds/lib/edsf-persona.vala | 46 +++++++++++++++++++++++++---------- 2 files changed, 35 insertions(+), 13 deletions(-) commit 525679227287ca21270c996762864be1f4962323 Author: Raul Gutierrez Segales Date: Wed Sep 7 22:59:41 2011 +0100 e-d-s: move Set comparison method into it's own class This refactoring is so we can reuse the method with other types. backends/eds/lib/Makefile.am | 1 + backends/eds/lib/edsf-persona-store.vala | 36 +-------------------------- backends/eds/lib/edsf-persona.vala | 25 ++++++++++--------- backends/eds/lib/edsf-util.vala | 38 ++++++++++++++++++++++++++++++ 4 files changed, 54 insertions(+), 46 deletions(-) commit cd1fd7f6cdd9ba89b248eb6096d43f9d8a660af0 Author: Philip Withnall Date: Tue Sep 6 22:22:52 2011 +0100 Bug 656689 — Re-link personas on linkable properties being changed Listen for notifications of changes to the linkable properties of every persona in the IndividualAggregator. When we receive such a notification, relink that persona by artificially removing them from the aggregator and immediately re-adding them. Like many things in the IndividualAggregator, this is ugly — but it appears to work, and I can get my head around it. Closes: bgo#656689 folks/individual-aggregator.vala | 45 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 45 insertions(+), 0 deletions(-) commit 7b74199aeed817fb4b08ee45e427c161fa7d9088 Author: Philip Withnall Date: Tue Sep 6 22:20:12 2011 +0100 core: Fix individuals_changed_detailed mappings for unlinked individuals It turns out that we can do a post-processing phase on the mappings to be emitted by IndividualAggregator.individuals_changed_detailed and ensure that individuals who've been unlinked are represented by a mapping from themselves to the set of individuals replacing them, rather than a mapping from themselves to null, and null to the set of individuals replacing them. This probably isn't the most efficient way to fix the problem, but it works and I can just about understand it. Helps: bgo#656689, bgo#657282 folks/individual-aggregator.vala | 27 +++++++++++++++++++++++++-- 1 files changed, 25 insertions(+), 2 deletions(-) commit 55abd8380a639d7e475483fcd0121d7b6552d51c Author: Philip Withnall Date: Tue Sep 6 22:16:44 2011 +0100 core: Be more thorough when removing individuals from the link map Since the values of personas' linkable properties could've changed since we added them to the link map, we have to be more thorough when removing individuals from the map. We therefore now remove them by examining all the values in the map, and removing every mapping to the individual we're interested in. Helps: bgo#656689 folks/individual-aggregator.vala | 51 +++++++++++++++----------------------- 1 files changed, 20 insertions(+), 31 deletions(-) commit fa1fb9f4ab151268fd2eee16a1afe7c2f87e5f42 Author: Philip Withnall Date: Tue Sep 6 22:10:20 2011 +0100 core: Add more debug output and validation to the IndividualAggregator Everyone loves debug output, and validating that we aren't leaving stale entries in the link map which will later cause whoever's looking into aggregator bugs to hide in a corner and cry. Helps: bgo#656689 folks/individual-aggregator.vala | 29 +++++++++++++++++++++++++++-- 1 files changed, 27 insertions(+), 2 deletions(-) commit 6ed7d51617cc9b2aa141497d7437c8b7247cbf40 Author: Philip Withnall Date: Tue Sep 6 22:04:20 2011 +0100 core: Clarify that Persona.linkable_properties doesn't change at runtime Helps: bgo#656689 folks/persona.vala | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit 150b7579f1069f561f2069c9efad864b9c87e2e9 Author: Philip Withnall Date: Tue Sep 6 21:57:42 2011 +0100 core: Ensure we always notify of new Individuals In the following situation, it was possible for IndividualAggregator.individuals_changed_detailed to not emit a notification that an individual was added: If two personas were added by a given store in the same emission of PersonaStore.personas_changed, the IA would create an Individual, i1, from the first and add a mapping (null → i1) to the change set. It would then process the second, destroying the first individual and creating a new Individual, i2, (correctly) containing both personas. In doing so, it would remove the mapping (null → i1) from the change set, but would incorrectly not add a mapping (null → i2) in its place. This situation can be extended to others where a single new Individual is formed from multiple new personas coming from a single emission of PersonaStore.personas_changed. Closes: bgo#657282 (again) folks/individual-aggregator.vala | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) commit b9f391ab8c4170772b27c81b0e1ce651ec37360d Author: Raul Gutierrez Segales Date: Wed Sep 7 15:52:27 2011 +0100 e-d-s: kill gconfd-2 after running a test I thought we were properly cleaning up the GConf entries generated by each test run but it turns out that sometimes gconfd-2 exits /after/ we've supposedly nuked it's directory. So before cleaning up GConf's files we now kill gconfd-2 to prevent it from sync-ing to disc afterwards. Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658327 tests/tools/with-session-bus-eds.sh | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) commit 01595d5d8198dcc6b40606b12fc931764d4e47e3 Author: Travis Reitter Date: Wed Sep 7 14:23:39 2011 -0700 Bump required Vala version. This avoids breaking the build due to valac --fatal-warnings for our internal code. configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit c22db00640915ee9c31290542fe23e70de6e024e Author: Travis Reitter Date: Wed Sep 7 14:17:53 2011 -0700 Update for translatable strings in group-details po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) commit 913528c050823bf079c5e5eceb21b0895cf96012 Author: Travis Reitter Date: Wed Sep 7 11:37:12 2011 -0700 Fix birthday calculation in eds tests. It's not nice to discriminate against people born outside of UTC. tests/eds/add-persona.vala | 2 +- tests/eds/set-birthday.vala | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 7729cea0f4e9db17ea0de77c067430894c0a485b Author: Matej Urbančič Date: Wed Sep 7 15:36:23 2011 +0200 Updated Slovenian translation po/sl.po | 28 ++++++++++++++-------------- 1 files changed, 14 insertions(+), 14 deletions(-) commit 00ef2222f0f93aa6999e549834243f9430ba5a97 Author: Bruce Cowan Date: Wed Sep 7 13:47:10 2011 +0100 Added British English translation po/LINGUAS | 1 + po/en_GB.po | 729 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 730 insertions(+), 0 deletions(-) commit 3032f1873a6a28ecf8d459d7e3502813d8d38a3c Author: Raul Gutierrez Segales Date: Wed Sep 7 12:42:31 2011 +0100 e-d-s: remove invalid assertion in set-roles test case tests/eds/set-roles.vala | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) commit 3959555f24f7696bcda9af7e265682997c1076d0 Author: Raul Gutierrez Segales Date: Wed Sep 7 12:41:09 2011 +0100 e-d-s: free resources properly between tests cases on link-persona test unit tests/eds/link-personas.vala | 21 ++++++++++++++------- 1 files changed, 14 insertions(+), 7 deletions(-) commit c4e1477efca0d19ab9a97949063542391eca8d81 Author: Raul Gutierrez Segales Date: Wed Sep 7 12:32:08 2011 +0100 e-d-s: eliminate another case of possible WebServiceFieldDetails with null value backends/eds/lib/edsf-persona.vala | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) commit 9d28ee42ff7809698ae0ed35b74c2ae08882b404 Author: Raul Gutierrez Segales Date: Wed Sep 7 11:55:08 2011 +0100 e-d-s: don't instantiate WebServiceFieldDetails with null values Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658327 tests/eds/link-personas.vala | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) commit 220f8658610ed29c4187ea8e7869a05bedb1b062 Author: Raul Gutierrez Segales Date: Wed Sep 7 11:23:34 2011 +0100 libsocialweb: update bug link in lsw for quiescence support backends/libsocialweb/lib/swf-persona-store.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 00a31f63bcc266a53b2e5c6fa1df79cab4f8a664 Author: Philip Withnall Date: Sat Sep 3 18:36:24 2011 +0100 Bug 657783 — Prefer data from primary store when picking Individual values Use a consistent high-level order over personas in an individual to choose which one to use for the value of single-valued properties such as alias, avatar and gender. Closes: bgo#657783 NEWS | 1 + folks/individual.vala | 573 +++++++++++++++++++++++++++++-------------------- 2 files changed, 336 insertions(+), 238 deletions(-) commit 23027313a91d8ee86d43d445402628378a020739 Author: Philip Withnall Date: Sat Sep 3 18:35:24 2011 +0100 core: Clarify nullability of a few properties AliasDetails.alias, NameDetails.nickname and NameDetails.full_name must never be set to null. The empty string represents an unset value for these properties. backends/eds/lib/edsf-persona-store.vala | 19 +++++++++++++++++-- backends/eds/lib/edsf-persona.vala | 14 +++++++++++++- backends/key-file/kf-persona.vala | 14 +++++++++++++- backends/libsocialweb/lib/swf-persona.vala | 14 +++++++++++++- backends/telepathy/lib/tpf-persona-store.vala | 6 ++++++ backends/telepathy/lib/tpf-persona.vala | 11 ++++++++++- backends/tracker/lib/trf-persona.vala | 21 ++++++++++++++++++--- folks/alias-details.vala | 2 ++ folks/name-details.vala | 6 ++++++ 9 files changed, 98 insertions(+), 9 deletions(-) commit 9daadb602785e3aba2584fee922ed88150ee1c34 Author: Matej Urbančič Date: Tue Sep 6 22:44:04 2011 +0200 Updated Slovenian translation po/sl.po | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) commit 1d89ac066b90e54ccbefd618960f5c50a7217ce0 Author: Matej Urbančič Date: Tue Sep 6 22:42:33 2011 +0200 Added sl for Slovenian translation po/LINGUAS | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit a7cef2750ef2fd4502a2463ea7c6ff8a7ccd243d Author: Matej Urbančič Date: Tue Sep 6 22:42:19 2011 +0200 Added Slovenian translation po/sl.po | 708 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 708 insertions(+), 0 deletions(-) commit 9d82eca34fa964b1edc7b2eb94a6f6dfe73630a6 Author: Philip Withnall Date: Sun Sep 4 18:14:04 2011 +0100 aggregator: Fix a typo in emit_individuals_changed() folks/individual-aggregator.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 1a794bec77dbeadc0f9d7f3d5b6c6634ada26fd8 Author: Philip Withnall Date: Sun Sep 4 17:49:26 2011 +0100 aggregator: Remove a useless duplicated set This appears to be lingering from the dark days when we used GLib.List. folks/individual-aggregator.vala | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) commit 43963c6c4df92013e706cde6ece73dd891ca42b0 Author: Philip Withnall Date: Sun Sep 4 15:03:15 2011 +0100 aggregator: Factor out code to add personas to the link map This doesn't change behaviour at all (apart from debug messages), but should make the code a bit more maintainable. folks/individual-aggregator.vala | 95 +++++++++++++++++++------------------ 1 files changed, 49 insertions(+), 46 deletions(-) commit eff9dfdbd8f82167764a2064d0c4731c2cb678b7 Author: Raul Gutierrez Segales Date: Tue Sep 6 13:05:45 2011 +0100 Workaround for Tpf.PersonaStores with no stored channels support Helps: https://bugzilla.gnome.org/show_bug.cgi?id=656184 backends/telepathy/lib/tpf-persona-store.vala | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) commit 21115d35329c10b5136880117edaf66d5c698a9a Author: Raul Gutierrez Segales Date: Sun Sep 4 15:21:44 2011 +0100 e-d-s: add test case for settings roles tests/eds/Makefile.am | 6 ++ tests/eds/set-roles.vala | 161 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 167 insertions(+), 0 deletions(-) commit c0969ff08c7f67ea0118e24e7b9d5c70175e13e9 Author: Raul Gutierrez Segales Date: Sat Sep 3 20:30:12 2011 +0100 e-d-s: extend add persona test to handle Roles tests/eds/add-persona.vala | 24 ++++++++++++++++++++++++ 1 files changed, 24 insertions(+), 0 deletions(-) commit 6d5040f72929231894e02632827ba9135552ef5b Author: Raul Gutierrez Segales Date: Sat Sep 3 18:28:09 2011 +0100 e-d-s: implement support for RoleDetails Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657969 NEWS | 1 + backends/eds/lib/edsf-persona-store.vala | 135 +++++++++++++++++++++++++++ backends/eds/lib/edsf-persona.vala | 146 ++++++++++++++++++++++++++++++ 3 files changed, 282 insertions(+), 0 deletions(-) commit 50a9aebbf9694e04030c4528ce93751396728b4f Author: Raul Gutierrez Segales Date: Mon Sep 5 23:33:08 2011 +0100 build: tests don't use so add path to folks/ tests/eds/Makefile.am | 1 + tests/lib/eds/Makefile.am | 2 ++ tests/lib/tracker/Makefile.am | 1 + tests/libsocialweb/Makefile.am | 1 + tests/telepathy/Makefile.am | 1 + tests/tracker/Makefile.am | 1 + 6 files changed, 7 insertions(+), 0 deletions(-) commit 81d9e2ca8c24d589c463d6ea7c637315122d3292 Author: Raul Gutierrez Segales Date: Mon Sep 5 22:25:56 2011 +0100 libsocialweb: make PersonaStores immediately quiescent Because we don't know if a libsocialweb service has 0 contacts or is not well configured or is not authenticated, etc.; we might end up forever for contacts to arrive and never achieve quiescence. Until libsocialweb provides us with more information about the status of service (is it configured and authenticated? How many contacts should we receive? etc.) we immediately declare it quiescent after preparing it. backends/libsocialweb/lib/swf-persona-store.vala | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) commit 0ee29949100e6211775bd98527740e535db97bbf Author: Philip Withnall Date: Mon Sep 5 19:53:45 2011 +0100 telepathy: Potentially fix is-quiescent See: bgo#656184 backends/telepathy/lib/tpf-persona-store.vala | 14 +++++++++++++- 1 files changed, 13 insertions(+), 1 deletions(-) commit 79ce988289f76016c8c61e158ef0d2c8525b4731 Author: Philip Withnall Date: Mon Sep 5 21:27:27 2011 +0100 eds: Immediately make non-browseable Edsf.PersonaStores reach quiescence For example, some LDAP servers may not be browseable (i.e. they're search only), so should reach quiescence immediately. This prevents the IndividualAggregator waiting for ever for them to become quiescent. Helps: bgo#656184 backends/eds/lib/edsf-persona-store.vala | 36 ++++++++++++++++++++++++++++++ 1 files changed, 36 insertions(+), 0 deletions(-) commit 13c39840214c5f775c33b9aba151239cff793f36 Author: Mario Blättermann Date: Mon Sep 5 21:06:19 2011 +0200 [l10n] Updated German translation po/de.po | 514 +++++++++++++++++++++++++++++++++++++++++++------------------- 1 files changed, 355 insertions(+), 159 deletions(-) commit d7e1a077163e5b1f216bf55405280b0c577b460c Author: dmustieles Date: Mon Sep 5 13:45:53 2011 +0200 Updated Spanish translation po/es.po | 51 ++++++++++++++++++++++++++++----------------------- 1 files changed, 28 insertions(+), 23 deletions(-) commit 8a8fd46977395221c11a5bb42bdd538c54236ebf Author: Fran Dieguez Date: Mon Sep 5 00:17:10 2011 +0200 Updated galician translations po/LINGUAS | 4 +- po/gl.po | 738 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 741 insertions(+), 1 deletions(-) commit 8a4d6afc237e9ea1a3b845bd32ed41b48795c58b Author: Philip Withnall Date: Mon Aug 29 21:59:02 2011 +0100 tests: Port the remaining tests to use individuals_changed_detailed Helps: bgo#657282 tests/eds/add-contacts-stress-test.vala | 22 +++++++---- tests/eds/add-persona.vala | 20 ++++++---- tests/eds/avatar-details.vala | 21 ++++++---- tests/eds/email-details.vala | 22 +++++++---- tests/eds/im-details.vala | 22 +++++++---- tests/eds/individual-retrieval.vala | 22 +++++++---- tests/eds/link-personas.vala | 27 ++++++++---- tests/eds/name-details.vala | 22 +++++++---- tests/eds/phone-details.vala | 22 +++++++---- tests/eds/postal-address-details.vala | 22 +++++++---- tests/eds/remove-persona.vala | 23 +++++++--- tests/eds/removing-contacts.vala | 23 +++++++--- tests/eds/set-avatar.vala | 22 +++++++---- tests/eds/set-birthday.vala | 22 +++++++---- tests/eds/set-emails.vala | 22 +++++++---- tests/eds/set-gender.vala | 22 +++++++---- tests/eds/set-im-addresses.vala | 22 +++++++---- tests/eds/set-names.vala | 24 +++++++---- tests/eds/set-notes.vala | 22 +++++++---- tests/eds/set-phones.vala | 22 +++++++---- tests/eds/set-postal-addresses.vala | 22 +++++++---- tests/eds/set-properties-race.vala | 22 +++++++---- tests/eds/set-structured-name.vala | 22 +++++++---- tests/eds/set-urls.vala | 22 +++++++---- tests/eds/updating-contacts.vala | 22 +++++++---- tests/key-file/individual-retrieval.vala | 25 ++++++++++-- tests/libsocialweb/aggregation.vala | 33 +++++++++++++-- tests/libsocialweb/dummy-lsw.vala | 32 ++++++++++++--- tests/telepathy/individual-properties.vala | 42 +++++++++++++++++--- tests/telepathy/individual-retrieval.vala | 31 ++++++++++++-- tests/tracker/add-contact.vala | 22 +++++++---- tests/tracker/add-persona.vala | 22 +++++++---- tests/tracker/additional-names-updates.vala | 22 +++++++---- tests/tracker/avatar-details-interface.vala | 22 +++++++--- tests/tracker/avatar-updates.vala | 22 +++++++---- tests/tracker/birthday-details-interface.vala | 23 +++++++---- tests/tracker/birthday-updates.vala | 23 +++++++---- tests/tracker/default-contact.vala | 22 +++++++---- tests/tracker/duplicated-emails.vala | 22 +++++++---- tests/tracker/duplicated-phones.vala | 22 +++++++---- tests/tracker/email-details-interface.vala | 24 +++++++---- tests/tracker/emails-updates.vala | 22 +++++++---- tests/tracker/family-name-updates.vala | 22 +++++++---- tests/tracker/favourite-details-interface.vala | 24 +++++++---- tests/tracker/favourite-updates.vala | 22 +++++++---- tests/tracker/fullname-updates.vala | 22 +++++++---- tests/tracker/gender-details-interface.vala | 23 +++++++---- tests/tracker/given-name-updates.vala | 22 +++++++---- tests/tracker/im-details-interface.vala | 24 +++++++---- tests/tracker/imaddresses-updates.vala | 22 +++++++---- tests/tracker/individual-retrieval.vala | 22 +++++++---- tests/tracker/link-personas-via-local-ids.vala | 29 +++++++++---- tests/tracker/link-personas.vala | 29 +++++++++---- tests/tracker/match-all.vala | 22 +++++++---- tests/tracker/match-email-addresses.vala | 22 +++++++---- tests/tracker/match-im-addresses.vala | 22 +++++++---- tests/tracker/match-known-emails.vala | 22 +++++++---- tests/tracker/match-name.vala | 22 +++++++---- tests/tracker/match-phone-number.vala | 22 +++++++---- tests/tracker/name-details-interface.vala | 24 +++++++---- tests/tracker/nickname-updates.vala | 22 +++++++---- tests/tracker/note-details-interface.vala | 22 +++++++---- tests/tracker/phone-details-interface.vala | 24 +++++++---- tests/tracker/phones-updates.vala | 23 +++++++---- .../tracker/postal-address-details-interface.vala | 22 +++++++---- tests/tracker/prefix-name-updates.vala | 23 +++++++---- tests/tracker/remove-contact.vala | 25 ++++++++---- tests/tracker/remove-persona.vala | 23 +++++++--- tests/tracker/role-details-interface.vala | 22 +++++++---- tests/tracker/set-avatar.vala | 22 +++++++---- tests/tracker/set-birthday.vala | 22 +++++++---- tests/tracker/set-duplicate-email.vala | 23 +++++++---- tests/tracker/set-emails.vala | 22 +++++++---- tests/tracker/set-favourite.vala | 22 +++++++---- tests/tracker/set-full-name.vala | 22 +++++++---- tests/tracker/set-gender.vala | 22 +++++++---- tests/tracker/set-im-addresses.vala | 22 +++++++---- tests/tracker/set-nickname.vala | 22 +++++++---- tests/tracker/set-notes.vala | 22 +++++++---- tests/tracker/set-null-avatar.vala | 22 +++++++---- tests/tracker/set-phones.vala | 22 +++++++---- tests/tracker/set-postal-addresses.vala | 22 +++++++---- tests/tracker/set-roles.vala | 22 +++++++---- tests/tracker/set-structured-name.vala | 22 +++++++---- tests/tracker/set-urls.vala | 22 +++++++---- tests/tracker/suffix-name-updates.vala | 22 +++++++---- tests/tracker/url-details-interface.vala | 24 +++++++---- tests/tracker/website-updates.vala | 22 +++++++---- 88 files changed, 1336 insertions(+), 695 deletions(-) commit 87b3c40a28fe8312f2f34630ebbb5f3981bb3a34 Author: Philip Withnall Date: Mon Aug 29 16:32:27 2011 +0100 tests: Expand the aggregation test to check both individuals_changed signals Helps: bgo#657282 tests/folks/Makefile.am | 3 + tests/folks/aggregation.vala | 543 ++++++++++++++++++++++++++++-------------- 2 files changed, 370 insertions(+), 176 deletions(-) commit 0dd7dc1aaa2e3b647f9e62d4a4960df60fd97220 Author: Philip Withnall Date: Wed Aug 24 22:38:16 2011 +0100 Bug 657282 — Add an IndividualAggregator.individuals_changed_detailed signal This supersedes IndividualAggregator.individuals_changed, providing more information about the relationships between the added and removed individuals. Closes: bgo#657282 NEWS | 3 + folks/individual-aggregator.vala | 222 ++++++++++++++++++++++++++------------ 2 files changed, 156 insertions(+), 69 deletions(-) commit f8fe0fb3ff4af3a727d46946a96d6d890ae93667 Author: Philip Withnall Date: Sun Sep 4 12:58:36 2011 +0100 Bug 657789 — Don't claim uneditable eds fields as writable Support setting the writeable-properties property of Edsf.Persona and the always-writeable-properties property of Edsf.PersonaStore from the set of supported fields exported by the address book. Closes: bgo#657789 NEWS | 1 + backends/eds/lib/edsf-persona-store.vala | 220 ++++++++++++++++++++++++++---- backends/eds/lib/edsf-persona.vala | 20 +--- 3 files changed, 199 insertions(+), 42 deletions(-) commit 3f71f115ee6afc747a47a4576e921e35713180ba Author: Philip Withnall Date: Sun Sep 4 12:56:36 2011 +0100 core: Add GROUPS and INVALID to PersonaDetail One is obviously necessary. The other is necessary for use as an error return from a function in the fix for bgo#657789. This also adds some bounds checking to PersonaStore.detail_key(), which can now return null if the PersonaDetail wasn't recognised. Helps: bgo#657789 NEWS | 1 + folks/persona-store.vala | 30 ++++++++++++++++++++++++++---- 2 files changed, 27 insertions(+), 4 deletions(-) commit 05eb522436c4f10f10f604a18e7f41454a78e3d6 Author: Raul Gutierrez Segales Date: Sun Sep 4 13:41:19 2011 +0100 e-d-s: simplify property checking in add-persona test tests/eds/add-persona.vala | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-) commit 7ed4677e0c78e31e4bf6f8357ff70db6af4c6690 Author: Daniel Mustieles Date: Sun Sep 4 12:02:48 2011 +0200 Updated Spanish translation po/es.po | 54 +++++++++++++++++++++++++++++------------------------- 1 files changed, 29 insertions(+), 25 deletions(-) commit 86d3828477d7687f251d54fb382a62c4176d7411 Author: Daniel Mustieles Date: Sun Sep 4 11:28:10 2011 +0200 Added Spanish translation to LINGUAS po/LINGUAS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 6b09a9184578ee44be82f4755eb5b651b485fee7 Author: Daniel Mustieles Date: Sun Sep 4 11:27:29 2011 +0200 Updated Spanish translation po/es.po | 712 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 712 insertions(+), 0 deletions(-) commit 5d6fe6a62375912f63d3ecc7c8cda33ebe68164a Author: Daniel Mustieles Date: Sun Sep 4 11:10:10 2011 +0200 Fixed typo in string («paramter») backends/tracker/lib/trf-persona-store.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 3b5dafb4d4d83ea65eab6800845b9bdd84d9995c Author: Raul Gutierrez Segales Date: Sat Sep 3 18:29:42 2011 +0100 e-d-s: add birthday to list of writeable properties backends/eds/lib/edsf-persona.vala | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit 8812d1a5bac69dcd6624e4239bb192151172d44a Author: Raul Gutierrez Segales Date: Sat Sep 3 15:37:53 2011 +0100 Update NEWS file NEWS | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 45eb4c58a231aedcea1dd28cd305254bbdcc7233 Author: Raul Gutierrez Segales Date: Sat Sep 3 13:58:31 2011 +0100 e-d-s: add test for setting birthday on an e-d-s Persona Helps: https://bugzilla.gnome.org/show_bug.cgi?id=657971 tests/eds/Makefile.am | 6 ++ tests/eds/set-birthday.vala | 153 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 159 insertions(+), 0 deletions(-) commit 53b36cddfe3b6e7b73b344c464f2a99449d9eb97 Author: Raul Gutierrez Segales Date: Sat Sep 3 13:49:58 2011 +0100 e-d-s: extend add-persona test to include the BirthdayDetails interface tests/eds/add-persona.vala | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) commit f7bbe3723cde7ba6a7ac91735a082366c9f52e70 Author: Raul Gutierrez Segales Date: Sat Sep 3 13:37:50 2011 +0100 e-d-s: implement BirthdayDetails Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657971 backends/eds/lib/edsf-persona-store.vala | 39 ++++++++++++++++ backends/eds/lib/edsf-persona.vala | 70 ++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+), 0 deletions(-) commit 0aa6c4815ffa6171f939b6fb419bd0ba184bbbca Author: Raul Gutierrez Segales Date: Sat Sep 3 15:13:22 2011 +0100 Documentation: state the birthday's DateTime objects are UTC folks/birthday-details.vala | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit 77ee30d3c8df1fab219ca7e0d1d08f6c263184c8 Author: Philip Withnall Date: Fri Sep 2 21:15:35 2011 +0100 Bug 656184 — Add is-quiescent property This allows clients to determine when the IndividualAggregator has reached a quiescent state — it's received and linked all of the personas it should do at startup, and from that point onwards will only relink personas in response to (for example), persona stores dynamically being added and removed at runtime. Closes: bgo#656184 NEWS | 3 + backends/eds/eds-backend.vala | 19 ++++ backends/eds/lib/edsf-persona-store.vala | 21 +++++ backends/key-file/kf-backend.vala | 19 ++++ backends/key-file/kf-persona-store.vala | 17 ++++ backends/libsocialweb/lib/swf-persona-store.vala | 23 +++++ backends/libsocialweb/sw-backend.vala | 19 ++++ backends/telepathy/lib/tpf-persona-store.vala | 64 +++++++++++++- backends/telepathy/tp-backend.vala | 19 ++++ backends/tracker/lib/trf-persona-store.vala | 18 ++++ backends/tracker/tr-backend.vala | 20 ++++ folks/backend-store.vala | 4 +- folks/backend.vala | 15 +++ folks/individual-aggregator.vala | 101 +++++++++++++++++++++- folks/persona-store.vala | 13 +++ 15 files changed, 371 insertions(+), 4 deletions(-) commit 823a6ae6b8bb63dbd50e5fae56793a20b1ee2d34 Author: Philip Withnall Date: Fri Sep 2 21:15:08 2011 +0100 eds/tracker: Ensure the PersonaStores are removed on error backends/eds/lib/edsf-persona-store.vala | 12 ++++++++++++ backends/tracker/lib/trf-persona-store.vala | 3 +++ 2 files changed, 15 insertions(+), 0 deletions(-) commit 17dcda00c5a993989bde31d0beca5338d5937c0f Author: Philip Withnall Date: Fri Sep 2 19:27:33 2011 +0100 key-file: Yield when setting properties on new personas This fixes the libsocialweb aggregation test. Helps: bgo#657510 backends/key-file/kf-persona-store.vala | 22 ++++++++++++++++++---- 1 files changed, 18 insertions(+), 4 deletions(-) commit bc0141fb8317caa614e930cfecbb4cf437797bc2 Author: Philip Withnall Date: Wed Aug 31 22:21:15 2011 +0100 eds: Ensure that property changes are signalled before .change_*() returns We can't rely on E.BookClientView.objects_modified being emitted before E.BookClient.modify_contact() returns. In order to guarantee that the relevant properties will be notified before Edsf.Persona.change_*() returns, we therefore move all calls to modify_contact() into a new Edsf.PersonaStore._commit_modified_property() method, and block returning from that on receipt of a property change notification from e-d-s. However, we also add a timeout to _commit_modified_property() (defaulting to 30 seconds), so that if we don't receive a property change notification in that time period, we error out from the .change_*() method. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 259 +++++++++++++----------------- 1 files changed, 110 insertions(+), 149 deletions(-) commit 6166dda19b16af130b61f61f3ae3b2a92a49cba7 Author: Philip Withnall Date: Tue Aug 30 23:24:58 2011 +0100 core: Add GroupDetails.change_groups() This allows the groups of an implementing class to all be changed simultaneously, asynchronously and with proper error notification. Closes: bgo#657510 NEWS | 2 + backends/eds/lib/edsf-persona-store.vala | 6 ++-- backends/eds/lib/edsf-persona.vala | 17 +++++++--- backends/telepathy/lib/tpf-persona.vala | 46 +++++++++++++++------------ folks/group-details.vala | 20 ++++++++++++ folks/individual.vala | 51 +++++++++++++++++++++++++++--- 6 files changed, 109 insertions(+), 33 deletions(-) commit 6dd4365dbbc2fd317f1fb6287d9a1b1d6d765e77 Author: Philip Withnall Date: Tue Aug 30 20:34:32 2011 +0100 core: Add WebServiceDetails.change_web_service_addresses() This allows the web service addresses of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 4 +- backends/eds/lib/edsf-persona.vala | 19 +++++-- backends/key-file/kf-persona.vala | 83 +++++++++++++++------------ backends/libsocialweb/lib/swf-persona.vala | 6 +- backends/tracker/lib/trf-persona.vala | 19 +++++- folks/individual.vala | 4 +- folks/web-service-details.vala | 23 ++++++++ po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 9 files changed, 110 insertions(+), 50 deletions(-) commit a8f586f2cba4e46c0aba4190c8d0bb3c7575070e Author: Philip Withnall Date: Tue Aug 30 20:20:23 2011 +0100 core: Add UrlDetails.change_urls() This allows the URLs of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 6 +++--- backends/eds/lib/edsf-persona.vala | 15 +++++++++++---- backends/libsocialweb/lib/swf-persona.vala | 19 ++++++++----------- backends/tracker/lib/trf-persona.vala | 18 ++++++++++++++---- folks/individual.vala | 8 ++------ folks/url-details.vala | 22 ++++++++++++++++++++++ po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 8 files changed, 62 insertions(+), 28 deletions(-) commit 418a2f2338d131769f80b3d264b3b015c785114e Author: Philip Withnall Date: Tue Aug 30 20:11:53 2011 +0100 core: Add RoleDetails.change_roles() This allows the roles of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/tracker/lib/trf-persona.vala | 19 +++++++++++++++---- folks/individual.vala | 9 ++------- folks/role-details.vala | 22 ++++++++++++++++++++++ 3 files changed, 39 insertions(+), 11 deletions(-) commit aa87b4cb56a9466d69c1ed87439cc860e6181379 Author: Philip Withnall Date: Tue Aug 30 20:03:00 2011 +0100 core: Add PostalAddressDetails.change_postal_addresses() This allows the postal addresses of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 7 +++---- backends/eds/lib/edsf-persona.vala | 17 +++++++++++++---- backends/tracker/lib/trf-persona.vala | 20 ++++++++++++++++---- folks/individual.vala | 8 ++------ folks/postal-address-details.vala | 22 ++++++++++++++++++++++ 5 files changed, 56 insertions(+), 18 deletions(-) commit 22866a6481fdd49d4aa8731da302d6cf6c8e4d17 Author: Philip Withnall Date: Tue Aug 30 19:55:32 2011 +0100 core: Add PhoneDetails.change_phone_numbers() This allows the phone numbers of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 6 +++--- backends/eds/lib/edsf-persona.vala | 16 ++++++++++++---- backends/tracker/lib/trf-persona.vala | 19 +++++++++++++++---- folks/individual.vala | 8 ++------ folks/phone-details.vala | 22 ++++++++++++++++++++++ po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 7 files changed, 56 insertions(+), 17 deletions(-) commit e0a2bd2e7abddf6e47d78809ba45caab62099de9 Author: Philip Withnall Date: Tue Aug 30 19:47:26 2011 +0100 core: Add NoteDetails.change_notes() This allows the notes of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 6 +++--- backends/eds/lib/edsf-persona.vala | 16 ++++++++++++---- backends/tracker/lib/trf-persona.vala | 17 +++++++++++++---- folks/individual.vala | 9 ++------- folks/note-details.vala | 22 ++++++++++++++++++++++ po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 7 files changed, 54 insertions(+), 18 deletions(-) commit 0eb80decfd43b5488c3ad7f97dd13bfb540a67d0 Author: Philip Withnall Date: Sun Aug 28 22:06:57 2011 +0100 core: Add NameDetails.change_*() methods This allows the names of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 17 ++-- backends/eds/lib/edsf-persona.vala | 50 +++++++++---- backends/libsocialweb/lib/swf-persona.vala | 41 ++++++++-- backends/tracker/lib/trf-persona.vala | 55 ++++++++++---- folks/individual.vala | 110 +++++++++++++++++++--------- folks/name-details.vala | 62 ++++++++++++++++ po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 8 files changed, 255 insertions(+), 82 deletions(-) commit e80b364c31817f4b2d3e3876ec5112d64ef90c80 Author: Philip Withnall Date: Sun Aug 28 21:41:02 2011 +0100 core: Make NameDetails.structured_name nullable It effectively was before; now it's official. backends/eds/lib/edsf-persona.vala | 4 +- backends/libsocialweb/lib/swf-persona.vala | 2 +- backends/tracker/lib/trf-persona-store.vala | 18 +++++--- backends/tracker/lib/trf-persona.vala | 61 +++++++++++++++++++++++---- folks/individual.vala | 2 +- folks/name-details.vala | 2 +- 6 files changed, 70 insertions(+), 19 deletions(-) commit 825694c474ae97ef05434a812c5830364270c08f Author: Philip Withnall Date: Sun Aug 28 21:26:24 2011 +0100 core: Add LocalIdDetails.change_local_ids() This allows the local IDs of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 4 ++-- backends/eds/lib/edsf-persona.vala | 16 ++++++++++++---- backends/tracker/lib/trf-persona.vala | 22 ++++++++++++++++------ folks/individual.vala | 9 ++------- folks/local-id-details.vala | 22 ++++++++++++++++++++++ po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 7 files changed, 56 insertions(+), 19 deletions(-) commit 6130e1038959b358d00f62a57c36ab4093374136 Author: Philip Withnall Date: Sun Aug 28 21:19:55 2011 +0100 eds: Fix a typo in a doc comment backends/eds/lib/edsf-persona-store.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 55b9950994703e9f91dc6e03e961ac3c99bded28 Author: Philip Withnall Date: Sun Aug 28 21:12:45 2011 +0100 core: Add GenderDetails.change_gender() This allows the gender of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 4 ++-- backends/eds/lib/edsf-persona.vala | 15 +++++++++++---- backends/libsocialweb/lib/swf-persona.vala | 16 +++++++++++++--- backends/tracker/lib/trf-persona.vala | 16 ++++++++++++---- folks/gender-details.vala | 21 +++++++++++++++++++++ folks/individual.vala | 14 +++++++------- po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 8 files changed, 68 insertions(+), 20 deletions(-) commit 073dc310a0294bf5c26f2e31ebf4073a543db0f6 Author: Philip Withnall Date: Sun Aug 28 20:19:09 2011 +0100 core: Add FavouriteDetails.change_is_favourite() This allows the favouriteness of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/telepathy/lib/tpf-persona-store.vala | 8 ++-- backends/telepathy/lib/tpf-persona.vala | 26 ++++++++-- backends/tracker/lib/trf-persona.vala | 41 ++++++++++------ folks/favourite-details.vala | 21 ++++++++ folks/individual.vala | 65 ++++++++++++++++++++----- po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 7 files changed, 125 insertions(+), 38 deletions(-) commit b5d1fdefc24dc5d7c5b94f1332cdb4e7dce80ade Author: Philip Withnall Date: Sun Aug 28 19:58:21 2011 +0100 core: Add EmailDetails.change_email_addresses() This allows the e-mail addresses of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 7 +++---- backends/eds/lib/edsf-persona.vala | 17 +++++++++++++---- backends/tracker/lib/trf-persona.vala | 19 +++++++++++++++---- folks/email-details.vala | 22 ++++++++++++++++++++++ folks/individual.vala | 8 ++------ po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 7 files changed, 57 insertions(+), 18 deletions(-) commit a5517e657d92d95e295714bb2be97a93261a9d1a Author: Philip Withnall Date: Sun Aug 28 19:46:58 2011 +0100 core: Add BirthdayDetails.change_birthday() and .change_calendar_event_id() These allows the birthday (and its calendar event) of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/tracker/lib/trf-persona.vala | 19 +++++++++--- folks/birthday-details.vala | 42 ++++++++++++++++++++++++++++ folks/individual.vala | 48 ++++++++++++++++++++++++++------ po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 5 files changed, 97 insertions(+), 14 deletions(-) commit 847acb0b13f12afc68745b28bf9fbb5f323cc9c9 Author: Philip Withnall Date: Sun Aug 28 19:39:22 2011 +0100 core: Make BirthdayDetails.birthday nullable It effectively was before; now it's official. backends/tracker/lib/trf-persona.vala | 4 ++-- folks/birthday-details.vala | 7 ++++--- folks/individual.vala | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) commit a1db7b08184ee325bd5e8b22d6c361b784a3a2f2 Author: Philip Withnall Date: Sun Aug 28 19:33:18 2011 +0100 core: Add AvatarDetails.change_avatar() This allows the avatar of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 29 +++++++++++++++++++++------ backends/eds/lib/edsf-persona.vala | 19 ++++++++++++----- backends/libsocialweb/lib/swf-persona.vala | 19 ++++++++++++++--- backends/telepathy/lib/tpf-persona.vala | 18 +++++++++++++--- backends/tracker/lib/trf-persona.vala | 16 +++++++++++--- folks/avatar-details.vala | 22 +++++++++++++++++++++ folks/individual.vala | 16 ++++++++++++-- po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 9 files changed, 113 insertions(+), 28 deletions(-) commit e390bdd7b7a2b57260f94e0c0559d3a6f340d14c Author: Philip Withnall Date: Sat Aug 27 17:11:00 2011 +0100 core: Add ImDetails.change_im_addresses() This allows the IM addresses of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 6 +- backends/eds/lib/edsf-persona.vala | 16 +++- backends/key-file/kf-persona.vala | 111 +++++++++++++++------------- backends/libsocialweb/lib/swf-persona.vala | 3 +- backends/telepathy/lib/tpf-persona.vala | 3 +- backends/tracker/lib/trf-persona.vala | 19 ++++- folks/im-details.vala | 21 +++++ folks/individual.vala | 3 +- 8 files changed, 117 insertions(+), 65 deletions(-) commit ef3d3b73d80f7510f8817383a061f544b3ac0367 Author: Philip Withnall Date: Sat Aug 27 15:58:30 2011 +0100 core: Add AliasDetails.change_alias() This allows the alias of an implementing class to be changed asynchronously with proper error notification. Helps: bgo#657510 backends/eds/lib/edsf-persona-store.vala | 72 ++++++++++++++++++++++++++++++ backends/key-file/kf-persona.vala | 26 +++++++--- backends/telepathy/lib/tpf-persona.vala | 25 ++++++++--- folks/alias-details.vala | 21 +++++++++ folks/individual.vala | 68 ++++++++++++++++++---------- po/POTFILES.in | 1 + po/POTFILES.skip | 1 + 7 files changed, 176 insertions(+), 38 deletions(-) commit be2f014028b93c286886f3367b84ebf4a562ace8 Author: Philip Withnall Date: Sat Aug 27 16:25:37 2011 +0100 core: Add Folks.PropertyError Helps: bgo#657510 NEWS | 1 + folks/persona.vala | 31 +++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 0 deletions(-) commit a5faebb1d5a220c35222768524a3a71dab3c7d09 Author: Raul Gutierrez Segales Date: Fri Sep 2 11:19:59 2011 +0100 e-d-s: make sure we also remove GConf's configs before running tests Commit e0b99581 tries to remove GConf's config *after* a test execution. But if the test fails, clean up might not happen. So this commit adds try to remove configs *before* we start. tests/tools/with-session-bus-eds.sh | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit 1f5d9e4ad0fb233de3b468fd1b4098f8c65f4fd6 Author: Raul Gutierrez Segales Date: Fri Sep 2 10:55:24 2011 +0100 IndividualAggregator: check for the writeable store was wrong We were checking for matching type_id to see if a PersonaStore was the configured writeable store, instead we should do a pointer comparison. folks/individual-aggregator.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit fb6058167ca6eb110336c4345eef537822029b00 Author: Raul Gutierrez Segales Date: Fri Sep 2 00:18:57 2011 +0100 build: previous commit doesn't cover the tracker disabled case configure.ac | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit e4c941605f6ce0d2708da468e89abacf2b01a629 Author: Raul Gutierrez Segales Date: Thu Sep 1 23:16:27 2011 +0100 tracker: conditional compilation of GLib.SpawnError exception handling Starting Tracker 0.10.6, the GLib.SpawnError is exception is thrown when calling Tracker.Sparql.Connection.get (). So we need to test for the installed version and catch or not the exception, accordingly. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657650 configure.ac | 11 ++++++++++- tests/lib/tracker/Makefile.am | 5 +++++ tests/lib/tracker/backend.vala | 2 ++ 3 files changed, 17 insertions(+), 1 deletions(-) commit 06b2ec0174113024eaeac4e1dbedc57073f759e1 Author: Raul Gutierrez Segales Date: Thu Sep 1 16:40:11 2011 +0100 e-d-s: more coding style cleanup in the persona store test tests/eds/persona-store-tests.vala | 38 ++++++++++++++++++------------------ 1 files changed, 19 insertions(+), 19 deletions(-) commit fbdc16d50121c6fbc93c251938d20723d489ad91 Author: Raul Gutierrez Segales Date: Thu Sep 1 16:35:37 2011 +0100 e-d-s: remove unused variable from persona store test tests/eds/persona-store-tests.vala | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) commit 2678ff5e563d19ab059346ee5a3d51b8eeeb92fa Author: Raul Gutierrez Segales Date: Thu Sep 1 16:29:02 2011 +0100 e-d-s: make the persona stores test follow our coding style tests/eds/persona-store-tests.vala | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) commit 58bc8efd338248eb2a954c5409381ca8ea6860a4 Author: Raul Gutierrez Segales Date: Wed Aug 31 22:48:56 2011 +0100 interface: throw some light on LocalIdDetail's cryptic comments folks/local-id-details.vala | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) commit a1a8c976ac18ad18474a684e4a48b953289ed518 Author: Raul Gutierrez Segales Date: Wed Aug 31 22:24:18 2011 +0100 tracker: update linking test to use iid instead of uid tests/tracker/link-personas-via-local-ids.vala | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) commit e32d9bac78db8a84a0ce3bb83e43e26ea3eb68d3 Author: Raul Gutierrez Segales Date: Wed Aug 31 23:03:10 2011 +0100 tracker: use iid instead of uid when linking via local ids backends/tracker/lib/trf-persona.vala | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 304e00323f57a2d0836993f5a6bf37882f60ddcf Author: Raul Gutierrez Segales Date: Wed Aug 31 19:57:07 2011 +0100 e-d-s: add test to link personas from different stores This test checks what was fixed in: https://bugzilla.gnome.org/show_bug.cgi?id=657635 tests/eds/link-personas.vala | 56 +++++++++++++++++++++++++++++++++--------- 1 files changed, 44 insertions(+), 12 deletions(-) commit b5750b7b1e37a924984cce3e045b6a4f385feba8 Author: Raul Gutierrez Segales Date: Wed Aug 31 17:01:11 2011 +0100 e-d-s: make address book uri a settable property in the test Backend This allows us to instantiate multiple Backends, each one associated to a it's own address book, which comes in handy for tests involving multiple e-d-s PersonaStores. tests/eds/link-personas.vala | 2 +- tests/lib/eds/backend.vala | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) commit 63b4ab7ab7be30e39936f7c0fd779481536a575e Author: Raul Gutierrez Segales Date: Mon Aug 29 18:27:48 2011 +0100 e-d-s: update link-personas test to use iid instead of contact_id tests/eds/link-personas.vala | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 5b44d73ebd013d649034001496ad79939efab372 Author: Raul Gutierrez Segales Date: Mon Aug 29 18:26:27 2011 +0100 e-d-s: use this.local_ids in linkable_property_to_links () Otherwise, this method can have a different behaviour depending on the state of the current Persona depending on whether this.local_ids was called before or not. backends/eds/lib/edsf-persona.vala | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) commit 19a426de3734cba718bc4bfa7372b2d8656ff614 Author: Raul Gutierrez Segales Date: Mon Aug 29 18:25:00 2011 +0100 e-d-s: we should use the Persona's iid as local-ids If we don't and use the contact_id as before, linking Personas from different PersonaStores won't work. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657635 NEWS | 1 + backends/eds/lib/edsf-persona.vala | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) commit 563830b0894682564e4d418353614a043809a2c0 Author: Raul Gutierrez Segales Date: Mon Aug 29 15:47:37 2011 +0100 e-d-s: default trust level for PersonaStores is PARTIAL Without this, we can't link personas from different (e-d-s) PersonaStores. Helps: https://bugzilla.gnome.org/show_bug.cgi?id=657635 backends/eds/lib/edsf-persona-store.vala | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit e0b99581db47b4811ef735813b21fe96ee48373a Author: Raul Gutierrez Segales Date: Wed Aug 31 21:27:39 2011 +0100 e-d-s: make sure we remove GConf's configs between tests When exercising GConf more than the usual, by creating multiple address books or such, we might leave things in an inconsistent state that might affect the tests that come afterwards. tests/tools/with-session-bus-eds.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 31f33c548dd855a9230f27b0257fe201fa76d23a Author: Philip Withnall Date: Wed Aug 31 19:30:10 2011 +0100 tracker: Fix the match-im-addresses test Due to the Tracker tests now running with the tracker persona store as the writeable store, Tracker personas in the tests are now linked by their linkeable properties (as their persona store is now fully trusted due to being the writeable store). This caused the two personas in the match-im-addresses test to be linked together implicitly by the aggregator, when the test case assumed they weren't. This broke the test. This commit fixes the test permanently by changing the way we consider potential matches based on IM addresses. Previously, we only indicated a potential match if the two individuals under consideration shared a common IM address + protocol combination. This commit changes that so that two individuals are now considered to potentially match if they share a common IM address *only*. Protocols are no longer considered. This allows us to change the way the personas are set up in the match-im-addresses test so that they're no longer implicitly linked by the aggregator. folks/potential-match.vala | 21 ++++++++++++--------- tests/tracker/match-im-addresses.vala | 5 ++--- 2 files changed, 14 insertions(+), 12 deletions(-) commit ee2ec7c7f14316e3a713b7402a44e12dea4b6623 Author: Raul Gutierrez Segales Date: Wed Aug 31 15:19:53 2011 +0100 e-d-s: fix indentation in tests backend tests/lib/eds/backend.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 061fdce9824dbbc2b41b3a239acf213d88e94bad Author: Raul Gutierrez Segales Date: Wed Aug 31 12:19:00 2011 +0100 build: Bump the e-d-s dependency to 3.1.5 We totally missed this on previous releases and it is now causing problems for packagers. configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit a44e2df4d696b2ceb1740e83196fd1943d60664f Author: Philip Withnall Date: Tue Aug 9 18:23:12 2011 +0200 Bug 653777 — Add a helper function to create a writable persona This adds IndividualAggregator.ensure_individual_property_writeable(), which returns a persona which has the specified property writeable in the specified individual. If no such persona exists already, a new one is created and linked to the individual. If that all fails, an error is returned. This allows for clients to write to properties of personas with confidence that the updates will be written out to the backend stores. (Achieved by calling IndividualAggregator.ensure_individual_property_writeable() first and only writing to the property if that call succeeds.) Closes: bgo#653777 NEWS | 4 + folks/individual-aggregator.vala | 130 ++++++++++++ tests/folks/aggregation.vala | 409 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 543 insertions(+), 0 deletions(-) commit 659d0c0b1dfb7123ee14c9cefe53696dd4dfb951 Author: Philip Withnall Date: Thu Aug 11 13:57:25 2011 +0200 key-file: Allow empty Kf.Personas to be added to the persona store This is necessary for the tests for bgo#653777. It removes the error which would previously be thrown when trying to add a persona to Kf.PersonaStore with no properties. Helps: bgo#653777 backends/key-file/kf-persona-store.vala | 18 ++---------------- 1 files changed, 2 insertions(+), 16 deletions(-) commit 9ce804c7b3f712eb43121c1ef9cf17e0cf75bcc8 Author: Philip Withnall Date: Thu Aug 11 13:55:10 2011 +0200 core: Add PersonaStore:always-writeable-properties This complements Persona:writeable-properties, listing the properties which are guaranteed to always be writeable on the personas in a given persona store. This is in contrast to Persona:writeable-properties, which may list extra properties which are only writeable on that particular persona. This could be the case with, for example, personas representing the user, which might have extra writeable properties to allow the user to change their alias or avatar. Helps: bgo#653777 NEWS | 3 ++ backends/eds/lib/edsf-persona-store.vala | 26 ++++++++++++++++++++ backends/key-file/kf-persona-store.vala | 17 +++++++++++++ backends/libsocialweb/lib/swf-persona-store.vala | 17 +++++++++++++ backends/telepathy/lib/tpf-persona-store.vala | 15 +++++++++++ backends/tracker/lib/trf-persona-store.vala | 28 ++++++++++++++++++++++ folks/persona-store.vala | 19 +++++++++++++++ 7 files changed, 125 insertions(+), 0 deletions(-) commit 187cde2cdb9e054e945aaa18494f869cd72fa6a8 Author: Travis Reitter Date: Mon Aug 29 13:32:06 2011 -0700 Fix NEWS: there never was a 0.5.3 release. NEWS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit ee86dd37f5fdfde94817d953228eb0394ea628d1 Author: Travis Reitter Date: Mon Aug 29 10:58:24 2011 -0700 Use the key-file backend for writes in general tests. See commit ef36f347 for more details. tests/folks/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 8fbf7ea3a1309c64addac4b99ffbc59189ef7bce Author: Raul Gutierrez Segales Date: Mon Aug 29 12:17:15 2011 +0100 Post-release version bump configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit ac08620c95aa0b02465d44790137cbc079aa00d0 Author: Philip Withnall Date: Mon Aug 29 12:16:44 2011 +0100 build: Fix the NEWS file More haste, less speed… NEWS | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) commit b851568b7faf4f3ef9f89810e97165eaf37ec44b Author: Philip Withnall Date: Sat Aug 27 14:25:28 2011 +0100 Bug 645056 — TpLowlevel library should have only static public functions Remove the TpLowlevel class from the TpLowlevel library and instead place all the functions statically in the “FolksTpLowlevel” namespace. Closes: bgo#645056 NEWS | 1 + backends/telepathy/lib/Makefile.am | 3 +- backends/telepathy/lib/tp-lowlevel.c | 43 +----------------------- backends/telepathy/lib/tp-lowlevel.h | 38 ---------------------- backends/telepathy/lib/tpf-persona-store.vala | 39 +++++++++++----------- 5 files changed, 24 insertions(+), 100 deletions(-)