commit dca613c6af15bd156ed5ea6c5660e2c5810c53bb Author: Mario Sanchez Prada Date: Thu Aug 18 09:09:33 2011 +0200 Fix HUGE memory leak loading thumbnails for details window src/frogr-details-dialog.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 13d0d459b3d7b4dc90dc8a1451de60b90b5156af Author: Christophe Fergeau Date: Sun Aug 14 16:12:06 2011 +0200 fix generation of default icon list (#656519) frogr_main_view_init builds a list of icon to pass to gtk_window_set_default_icon_list. The generation of this list is incorrectly done, resulting in a series of 1-element lists being generated, leaking the previous list every time. This commit fixes the list generation. https://bugzilla.gnome.org/show_bug.cgi?id=656519 src/frogr-main-view.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) commit 76a6d18390cd071682d6fa4a1e47d7f6babd51b6 Author: Christophe Fergeau Date: Sun Aug 14 16:10:05 2011 +0200 fix memory leaks (#656519) Fix a few memory leaks found using G_SLICE=always-malloc valgrind --log-file=frogr.log --leak-check=full --num-callers=40 frogr and then uploading a photo. There are still a few leaks remaining, especially in code interacting with libsoup https://bugzilla.gnome.org/show_bug.cgi?id=656519 src/flicksoup/fsp-session.c | 3 +++ src/frogr-main-view.c | 6 ++++++ 2 files changed, 9 insertions(+), 0 deletions(-) commit 54f2d952e4fc15d108426eac0df7631f5acd3ad1 Author: Christophe Fergeau Date: Sun Aug 14 15:02:39 2011 +0200 fix use after free in _fetch_account_info_cb (#656519) valgrind reports ==9225== Invalid read of size 1 ==9225== at 0x4A079D8: strcmp (mc_replace_strmem.c:538) ==9225== by 0x41C9B6: _fetch_account_info_cb (frogr-controller.c:1503) ==9225== by 0x344F464D98: complete_in_idle_cb (gsimpleasyncresult.c:757) ==9225== by 0x344E0427EC: g_main_context_dispatch (gmain.c:2441) ==9225== by 0x344E042FC7: g_main_context_iterate (gmain.c:3092) ==9225== by 0x344E04360C: g_main_loop_run (gmain.c:3300) ==9225== by 0x4D7D36C: gtk_main (in /usr/lib64/libgtk-3.so.0.0.12) ==9225== by 0x41DE7D: frogr_controller_run_app (frogr-controller.c:2103) ==9225== by 0x434A30: main (main.c:110) ==9225== Address 0xd2d67b1 is 1 bytes inside a block of size 19 free'd ==9225== at 0x4A055FE: free (vg_replace_malloc.c:366) ==9225== by 0x344E049742: g_free (gmem.c:263) ==9225== by 0x40FBF6: frogr_account_set_fullname (frogr-account.c:405) ==9225== by 0x41C984: _fetch_account_info_cb (frogr-controller.c:1500) ==9225== by 0x344F464D98: complete_in_idle_cb (gsimpleasyncresult.c:757) ==9225== by 0x344E0427EC: g_main_context_dispatch (gmain.c:2441) ==9225== by 0x344E042FC7: g_main_context_iterate (gmain.c:3092) ==9225== by 0x344E04360C: g_main_loop_run (gmain.c:3300) ==9225== by 0x4D7D36C: gtk_main (in /usr/lib64/libgtk-3.so.0.0.12) ==9225== by 0x41DE7D: frogr_controller_run_app (frogr-controller.c:2103) ==9225== by 0x434A30: main (main.c:110) ==9225== This is caused by _fetch_account_info_cb doing old_username = frogr_account_get_username (priv->account); frogr_account_set_username (priv->account, auth_token->username); if (g_strcmp0 (old_username, auth_token->username)) .... frogr_account_get_username doesn't return a copied string but a direct pointer to the username string stored in the account. frogr_account_set_username frees that string before setting the new name, which will lead to the g_strcmp0 being done on already freed memory. https://bugzilla.gnome.org/show_bug.cgi?id=656519 src/frogr-controller.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) commit 0a523af4059cbbcb2cef7c3a589f72bbecf28107 Author: Mario Sanchez Prada Date: Sat Aug 13 14:03:02 2011 +0200 Fixed typo src/frogr-settings-dialog.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit dcba9aa741fda31be28cb9f677ee6ca8d495f901 Author: Alberto Garcia Date: Sat Aug 13 13:47:09 2011 +0300 Create the license type combo box when using GTK+ < 2.24 src/frogr-details-dialog.c | 1 + src/frogr-settings-dialog.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) commit bed28ed74eb1942e5f27f2ea3ad82d8cd7d12f41 Author: Mario Sanchez Prada Date: Sat Aug 13 01:24:30 2011 +0200 Force the config directory to be named 'frogr' src/frogr-config.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) commit 9428c119241f74d0d46e709f6e2afc81caa06609 Author: Mario Sanchez Prada Date: Sat Aug 13 01:20:01 2011 +0200 Just use 'open' always for opening URLs in the Mac src/frogr-util.c | 42 +++++++++++++++++++++++++++++++++++------- 1 files changed, 35 insertions(+), 7 deletions(-)